-
Notifications
You must be signed in to change notification settings - Fork 219
Build by version #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kevinthegreat1
wants to merge
27
commits into
FabricMC:main
Choose a base branch
from
kevinthegreat1:build-by-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Build by version #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
* Port to 1.21.5 * update reference mod to 1.21.8, excluding 'rendering/basic-concepts' * remove unused reference, fix block entity renderer text * update docs * Add a note on 1.21.6's change to text rendering * add block models page link to data generation setup page * remove the rendering concepts page from the navigator, minor fixes * update version numbers * sync with upstream, fix game tests, checkstyle fixes * fix typo * fix spotless violations --------- Co-authored-by: modmuss50 <[email protected]> Co-authored-by: Cassian Godsted <[email protected]> Co-authored-by: Miroma <[email protected]> (cherry picked from commit 9886aab)
Co-authored-by: Miroma <[email protected]> (cherry picked from commit 1e90bfc)
(cherry picked from commit 649c7a3)
…ce, link fix (FabricMC#359) (cherry picked from commit a9eefc9)
Co-authored-by: Miroma <[email protected]> (cherry picked from commit fef78e7)
(cherry picked from commit ffd92d1)
* Update first-item.md mod-id should be replace with specific mod-id, and shoud notice beginers, or will confusing them for lots time and i am the unlucky poor guy stucke for 2 hours!!!! * Update creating-a-project.md just remind user replace mod-id with id user set * Update creating-a-project.md litter change * Apply suggestions from code review --------- Co-authored-by: Miroma <[email protected]> (cherry picked from commit 70285c3)
* Added .useBlockPrefixedTranslationKey() * Update FabricDocsReferenceEnglishLangProvider.java removed duplicates * Update en_us.json * rerun datagen (cherry picked from commit 45413c6)
Co-authored-by: Kevin <[email protected]> Co-authored-by: Miroma <[email protected]> (cherry picked from commit 5f39b1a)
* Add running game tests * Fix gradle working directory * Apply suggestions from code review Co-authored-by: Miroma <[email protected]> * Remove xvfb * Use Loom production run tasks * Fix production run task configuration * Add client game test to prodClient * Only add game test jvm arg --------- Co-authored-by: Miroma <[email protected]> (cherry picked from commit a01712f)
* add page for setting up vscode, tips and re-arrange sidebar * address review comments * address review comments * address review comments * address review comments (cherry picked from commit 8d7d92f)
* Update rendering concepts page * Uncomment note in hud.md * Apply suggestions from code review --------- Co-authored-by: Miroma <[email protected]> (cherry picked from commit 054180d)
* Rendering in the world * Lint * Allow comments after block * Apply suggestions from code review Co-authored-by: Miroma <[email protected]> * Clean up phases * Update phases explanation --------- Co-authored-by: Miroma <[email protected]> (cherry picked from commit 5cf3406)
(cherry picked from commit 375656d)
* refactor getting started pages * remove ide tips and tricks page from miscellaneous * fix lint errors * rename files - drop `ide` subdir - drop `ide-` prefix - mv `setting-up-a-development-environment` to `setting-up` - the file doesn't even talk about setting up the IDE anymore * changes to IDE-specific pages - uniform titles - correct `prev`/`next` urls - fix broken link * ChoiceComponent * add "Choose Your IDE" pages * only show "Choose Your IDE" pages in sidebar --------- Co-authored-by: Miroma <[email protected]> (cherry picked from commit b542b28)
* Added Block Models page * Markdown lint changes * Minor tweaks * update block-models.md to 1.21.8, style changes, lint Signed-off-by: Fellteros <[email protected]> * made changes according to miroma's suggestions Co-authored-by: [email protected] Signed-off-by: Fellteros <[email protected]> * lint Signed-off-by: Fellteros <[email protected]> * Add nbsps where reasonable * Apply suggestion from @its-miroma * Apply suggestion from @its-miroma * Apply suggestion from @its-miroma * Small grammatical changes --------- Signed-off-by: Fellteros <[email protected]> Co-authored-by: Miroma <[email protected]> (cherry picked from commit a70cfe3)
(cherry picked from commit c67746a)
(cherry picked from commit a94fd40)
* update to 1.21.10 * fix markdown lint failures * address review comments (cherry picked from commit 950ae80)
Co-authored-by: Miroma <[email protected]> (cherry picked from commit d93d033)
Contributor
Author
|
Unfortunately, the preview seems to be janky with old versions. It gives a 404 but works once you reload the page. |
Contributor
Author
|
Unfortunately, memory usage seems to have gone up due to more versions and pages. This does not appear to be as scalable as imagined, but it's definitely still better than what we have currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
framework
Related to the VitePress framework
new-version
Related to a newer version of Minecraft
priority:high
This should be addressed before anything else
todo:verify
This needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a build script that builds the docs version by version and update workflows to use
build_by_version.build_by_versioncan run with default node RAM, and I've tested the two build options on my laptop (m1 macbook air).Generates identical html on the main branch*
* I didn't actually check all the files. I only checked a couple.