Replace deprecated PropertyFetchToMethodCallRector with custom rule
#1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PropertyFetchToMethodCallRector was deprecated in Rector 2.2.6 as it was considered too generic. This commit introduces a custom FakerPropertyToMethodCallRector that specifically handles the transformation of Faker\Generator property access to method calls. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
OskarStark
force-pushed
the
OskarStark/rector-deprecated-rule
branch
from
6acbd59 to
41af658
Compare
|
@OskarStark Thank you. I'm looking forward to #1008 😊 |
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Member
|
Also see #1008. |
Author
|
Didn't check before, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PropertyFetchToMethodCallRector was deprecated in Rector 2.2.6 as it was considered too generic. This commit introduces a custom FakerPropertyToMethodCallRector that specifically handles the transformation of Faker\Generator property access to method calls.
What is the reason for this PR?
Author's checklist
Summary of changes
Review checklist
CHANGELOG.mdcc @mvhirsch