Skip to content

Fix #223: apply check for default (interface) method in all applicable locations #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix #223: apply check for default (interface) method in all applicable locations #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...rc/main/java/com/fasterxml/jackson/module/afterburner/deser/PropertyMutatorCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ private <T extends OptimizedSettableBeanProperty<T>> void _addSettersUsingIf(Met
// to fix [Issue-5] (don't assume return type is 'void'), we need to:
Type returnType = Type.getType(method.getReturnType());

boolean isInterface = method.getDeclaringClass().isInterface();
boolean isInterface = isInterfaceMethod(method);
mv.visitMethodInsn(isInterface ? INVOKEINTERFACE : INVOKEVIRTUAL,
beanClassName, method.getName(), "("+type+")"+returnType, isInterface);
mv.visitInsn(RETURN);
Expand All @@ -318,7 +318,7 @@ private <T extends OptimizedSettableBeanProperty<T>> void _addSettersUsingIf(Met
if (mustCast) {
mv.visitTypeInsn(CHECKCAST, type.getInternalName());
}
isInterface = method.getDeclaringClass().isInterface();
isInterface = isInterfaceMethod(method);
mv.visitMethodInsn(isInterface ? INVOKEINTERFACE : INVOKEVIRTUAL,
beanClassName, method.getName(), "("+type+")"+returnType, isInterface);
mv.visitInsn(RETURN);
Expand Down Expand Up @@ -348,7 +348,7 @@ private <T extends OptimizedSettableBeanProperty<T>> void _addSettersUsingSwitch
if (mustCast) {
mv.visitTypeInsn(CHECKCAST, type.getInternalName());
}
boolean isInterface = method.getDeclaringClass().isInterface();
boolean isInterface = isInterfaceMethod(method);
mv.visitMethodInsn(isInterface ? INVOKEINTERFACE : INVOKEVIRTUAL,
beanClassName, method.getName(), "("+type+")"+returnType, isInterface);
mv.visitInsn(RETURN);
Expand Down
4 changes: 4 additions & 0 deletions release-notes/VERSION-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ Active maintainers:
=== Releases ===
------------------------------------------------------------------------

#223: IncompatibleClassChangeError when deserializing a class implementing
an interface with default get/set implementations
(reported by @avnersin)

2.16.0-rc1 (20-Oct-2023)

#181: (blackbird) BlackBird proxy object error in Java 17
Expand Down