-
Notifications
You must be signed in to change notification settings - Fork 18
chore: FWSS Contract Upgrade Dependencies Document #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
chore: create release issue template
chore: contract upgrade dependencies document
chore: update dependecies document
chore: update file name
| - [ ] Create tag/release manually on GitHub UI | ||
|
|
||
| ##### Upgrade PDP Implementation Contract in FWSS: | ||
| - [ ] Checkout the desired PDP tag you want to upgrade to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to say something about going into the pdp submodule in FWSS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear why we are doing this work from the submodule in FWSS. Why don't we do it PDP repo directly? Are we doing it to just to be certain that we're deploying the actual version in the FWS submodule for pdp?
| export IMPLEMENTATION_PATH="src/PDPVerifier.sol:PDPVerifier" # If executing from /pdp | ||
| ``` | ||
| - [ ] Use the `upgrade-contract.sh` script to upgrade the contract | ||
| - [ ] Verify upgrade on Calibnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain how?
| ``` | ||
| - [ ] Use the `upgrade-contract.sh` script to upgrade the contract | ||
| - [ ] Verify upgrade on Calibnet | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there followup steps of updating the contract address in the changelog (although I wish we didn't have this manual step, but I understand we're just documenting what happens now).
| ``` | ||
| - [ ] Use the `upgrade-contract.sh` script to upgrade the contract | ||
| - [ ] Verify upgrade on Calibnet | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to cover the calibration vs. mainnet case? Do we expect to do both?
Co-authored-by: Steve Loeppky <[email protected]>
Co-authored-by: Steve Loeppky <[email protected]>
docs: elaborate more on the release PR steps
…one/filecoin-services into phi/release_issue_template
|
Reminder to capture steps/deatils about verifying contracts.... Example: https://filecoinproject.slack.com/archives/C07CGTXHHT4/p1759839263065899 |
My bad. There is a detailed log of steps being taken in #254 which I assume will get generalized and recorded here. |
|
Some of the env-vars are changing in this PR: #279 (review) |
Towards: #212
Document the FWSS contract upgrade dependencies