-
-
Notifications
You must be signed in to change notification settings - Fork 23.4k
Add AI Badgr provider with chat model and embeddings support #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: miguelmanlyx <[email protected]>
…-another-one Add AI Badgr provider with OpenAI-compatible chat and embeddings
Summary of ChangesHello @miguelmanlyx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates AI Badgr as a new, optional AI provider, offering both chat completion and embedding functionalities. By leveraging its OpenAI-compatible endpoints, users can now seamlessly incorporate AI Badgr's capabilities into their workflows, enhancing the system's flexibility and range of AI-powered features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for AI Badgr as an OpenAI-compatible provider for both chat completions and embeddings. The changes are well-structured and follow the existing patterns in the codebase. I've identified a few areas for improvement to enhance robustness and consistency between the new nodes, particularly in handling optional parameters and configuration options. My feedback includes suggestions to prevent potential runtime issues and to ensure a more consistent user experience.
packages/components/nodes/embeddings/AIBadgrEmbedding/AIBadgrEmbedding.ts
Show resolved
Hide resolved
packages/components/nodes/embeddings/AIBadgrEmbedding/AIBadgrEmbedding.ts
Show resolved
Hide resolved
|
Feedback done |
Summary
Adds AI Badgr as an optional OpenAI-compatible provider with support for chat completions and embeddings.
Changes
ChatAIBadgrnode for chat model supportAIBadgrEmbeddingnode for embeddings supportAIBadgrApicredential configurationImplementation Details
ChatCometAPIfor chat modelsOpenAIEmbeddingCustomfor embeddingshttps://aibadgr.com/api/v1/v1/chat/completionsand/v1/embeddingsTesting
pnpm buildFiles Changed
packages/components/nodes/chatmodels/ChatAIBadgr/ChatAIBadgr.tspackages/components/nodes/embeddings/AIBadgrEmbedding/AIBadgrEmbedding.tspackages/components/credentials/AIBadgrApi.credential.tspackages/components/nodes/chatmodels/ChatAIBadgr/aibadgr.svgpackages/components/nodes/embeddings/AIBadgrEmbedding/aibadgr.svg