Conversation
vahancouver
requested review from
george-bafaloukas-forgerock,
rodrigoareis and
spetrov
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 36 minutes and 40 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes update SPM dependency constraints for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
george-bafaloukas-forgerock
left a comment
george-bafaloukas-forgerock
left a comment
There was a problem hiding this comment.
LGTM
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@iOS/swiftui-davinci/Davinci/Davinci.xcodeproj/project.pbxproj`:
- Around line 593-594: Three package references (A51313CB2D9C6C640086F846,
A51C18E62CF5247200A78241, A52877762D9C71C400B4885D) still use branch
constraints; update each package reference block to match the migrated reference
(A57584782D9DD9EC00AFD754) by replacing the branch-based spec with kind =
upToNextMajorVersion and minimumVersion = 2.0.0, and then update any
productDependency entries that point at those branch package refs to reference
the consolidated versioned package ref (or the new IDs if you add separate
versioned refs) so all 17 product dependencies use the 2.0.0
upToNextMajorVersion source rather than branch constraints.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ec39def7-a52f-4eb8-b055-bdd431a010a1
📒 Files selected for processing (6)
iOS/swiftui-davinci/Davinci/Davinci.xcodeproj/project.pbxprojiOS/swiftui-davinci/Davinci/Davinci/AccessTokenViewModel.swiftiOS/swiftui-davinci/Davinci/Davinci/LogOutViewModel.swiftiOS/swiftui-davinci/Davinci/Davinci/UserInfoViewModel.swiftiOS/swiftui-journey-module/JourneyModuleSample/JourneyModuleSample.xcodeproj/project.pbxprojiOS/swiftui-mfa/MfaSample/MfaSample.xcodeproj/project.pbxproj
| kind = upToNextMajorVersion; | ||
| minimumVersion = 2.0.0; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
file="iOS/swiftui-davinci/Davinci/Davinci.xcodeproj/project.pbxproj"
echo "Inspecting ping-ios-sdk package references and requirement styles in:"
echo " $file"
echo
rg -n -A4 -B2 'XCRemoteSwiftPackageReference "ping-ios-sdk"|branch =|kind =|minimumVersion =' "$file"Repository: ForgeRock/sdk-sample-apps
Length of output: 9040
Multiple ping-ios-sdk references still use branch constraints instead of version 2.0.0.
The project file contains four separate ping-ios-sdk package references. Only one (A57584782D9DD9EC00AFD754) has been migrated to kind = upToNextMajorVersion with minimumVersion = 2.0.0. The other three still use branch constraints:
- A51313CB2D9C6C640086F846 → branch "SDKS-3920-update-dependency-managers-6"
- A51C18E62CF5247200A78241 → branch "develop"
- A52877762D9C71C400B4885D → branch "SDKS-3920-update-dependency-managers-6"
This leaves 17 product dependencies pointing to branch-based package references instead of the 2.0.0 baseline, fragmenting the dependency resolution across both versioned and branch sources.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@iOS/swiftui-davinci/Davinci/Davinci.xcodeproj/project.pbxproj` around lines
593 - 594, Three package references (A51313CB2D9C6C640086F846,
A51C18E62CF5247200A78241, A52877762D9C71C400B4885D) still use branch
constraints; update each package reference block to match the migrated reference
(A57584782D9DD9EC00AFD754) by replacing the branch-based spec with kind =
upToNextMajorVersion and minimumVersion = 2.0.0, and then update any
productDependency entries that point at those branch package refs to reference
the consolidated versioned package ref (or the new IDs if you add separate
versioned refs) so all 17 product dependencies use the 2.0.0
upToNextMajorVersion source rather than branch constraints.
4 participants
SDKS-4944
[iOS][PingSDK] Update samples apps to the new Ping iOS SDK 2.0.0
Summary by CodeRabbit