feat(login-widget): react sample app for login widget#97
Merged
vatsalparikh merged 5 commits intomainfrom Mar 12, 2026
Merged
Conversation
vatsalparikh
requested review from
SteinGabriel,
ancheetah,
cerebrl and
ryanbas21
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
3b6ae0c to
c035579
Compare
SteinGabriel
requested changes
Mar 3, 2026
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
3 times, most recently
from
82cfe26 to
7ee49bb
Compare
SteinGabriel
requested changes
Mar 4, 2026
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
4 times, most recently
from
aae425a to
9a3143f
Compare
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
9a3143f to
d7bee1e
Compare
cerebrl
requested changes
Mar 6, 2026
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
This is looking really nice and clean. Left some comments to help provide some clarity with future implementations.
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
1acf86e to
02f0f14
Compare
…instead of a single global context sdks-4765
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
02f0f14 to
4a0f645
Compare
SteinGabriel
requested changes
Mar 10, 2026
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
5c5bf9e to
36a2894
Compare
…tialization instead of context
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
36a2894 to
65c79c0
Compare
SteinGabriel
previously approved these changes
Mar 10, 2026
Contributor
SteinGabriel
left a comment
SteinGabriel
left a comment
There was a problem hiding this comment.
Aside from the current CI issues, this PR looks solid and ready to be merged. Thanks @vatsalparikh.
…ity when journey completes and login fails sdks-4765
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
704d6ae to
c4304b6
Compare
Contributor
Author
The ci builds are now passing as expected! |
cerebrl
previously approved these changes
Mar 11, 2026
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
e83afa6 to
f7a316c
Compare
vatsalparikh
force-pushed
the
sdks-4765-react-sample-login-widget
branch
from
f7a316c to
c04e678
Compare
SteinGabriel
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://pingidentity.atlassian.net/browse/SDKS-4765
Files that help integrate react sample app with login widget: