Resolves issue #11: Now supports server version 3.2. Changes made in this PR:#195
Open
dongxinEric wants to merge 3 commits intoFoundationDB:masterfrom
Open
Resolves issue #11: Now supports server version 3.2. Changes made in this PR:#195dongxinEric wants to merge 3 commits intoFoundationDB:masterfrom
dongxinEric wants to merge 3 commits intoFoundationDB:masterfrom
Conversation
- Added support of the command 'find'. Note it only supports following options:
- filter
- sort
- projection
- hint (will be parsed out but not actually used yet.)
- skip
- limit
- batchSize
- maxTimeMS (will be parsed out but not actually used yet.)
- Added support of the command 'getMore' which will be used along with the new 'find' command;
- Added support of the command 'killCursors' which will again be used along with the combination of 'find' and 'getMore'
- Added support of the command 'explain' which will be used after 3.2 instead of the old OP_QUERY way
With these newly added commands, DocLayer server now broadcasts server version 3.2 to all incoming connections.
Will added tests in later commit(s).
Contributor
Author
|
Forgot to say this will resolve #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these newly added commands, DocLayer server now broadcasts server version 3.2 to all incoming connections.
Will added tests in later commit(s).
Manually tested Swift driver (
MongoKitten v5.1.11), Go driver (Mongo Gov3.0andv3.2) andPyMongo-3.6.1. All worked fine. Note that all our existing pytests are based onPyMongo-3.6.1which will automatically switch to use all the new commands if the server says it's on version3.2, and since all our tests can still run fine, that's a good indicator that PyMongo will just work fine with the changes.@apkar is still on vacation, but he will review this once he's back.