Add a safety check before changing coordinators #2373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
johscheuer
commented
Oct 2, 2025
Contributor
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
nicmorales9
reviewed
Oct 8, 2025
Contributor
nicmorales9
left a comment
nicmorales9
left a comment
There was a problem hiding this comment.
premise seems good but there are some seemingly-important TODOs left and I have some understanding-questions
johscheuer
force-pushed
the
safety-check-coordinator-changes
branch
from
28c9a54 to
2d9f9e4
Compare
nicmorales9
approved these changes
Oct 21, 2025
Contributor
nicmorales9
left a comment
nicmorales9
left a comment
There was a problem hiding this comment.
changes look good as long as we file an issue for crashlooping coordinators, also ideally fix the variable names as I did find it a bit confusing
Contributor
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Contributor
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
nicmorales9
approved these changes
Oct 22, 2025
Contributor
nicmorales9
left a comment
nicmorales9
left a comment
There was a problem hiding this comment.
latest commit looks good too!
Contributor
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #2246
Type of change
Discussion
Testing
CI will run e2e tests. I added some additional unit tests.
Documentation
Added docs for the new flags (in the flag help).
Follow-up