Skip to content

Python coverage improvements#245

Open
wlav wants to merge 9 commits intoFramework-R-D:mainfrom
wlav:python-coverage
Open

Python coverage improvements#245
wlav wants to merge 9 commits intoFramework-R-D:mainfrom
wlav:python-coverage

Conversation

@wlav
Copy link
Contributor

@wlav wlav commented Jan 9, 2026

Improvements to Python test coverage and fixes for issues thus uncovered. This code introduces a helper for annotating the same Python function for different C++ types, which is similar functionality as is being provided by #213, which would benefit from this helper.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2026
View reviewed changes
test/python/all_config.py
try:
config[42] # should raise
assert not "did not raise TypeError"
except TypeError:

Check notice

Code scanning / CodeQL

Empty except Note test

'except' clause does nothing but pass and there is no explanatory comment.
@wlav wlav mentioned this pull request Jan 9, 2026
Merged
@codecov
Copy link

codecov bot commented Jan 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/python/src/configwrap.cpp 88.88% 0 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (76.93%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   76.25%   76.93%   +0.68%     
==========================================
  Files         124      124              
  Lines        2733     2736       +3     
  Branches      475      475              
==========================================
+ Hits         2084     2105      +21     
+ Misses        452      439      -13     
+ Partials      197      192       -5
Flag Coverage Δ
unittests 76.93% <94.44%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/python/src/errorwrap.cpp 56.81% <ø> (ø)
plugins/python/src/modulewrap.cpp 42.12% <100.00%> (+1.34%) ⬆️
plugins/python/src/pymodule.cpp 64.58% <100.00%> (ø)
plugins/python/src/wrap.hpp 100.00% <ø> (ø)
plugins/python/src/configwrap.cpp 96.15% <88.88%> (+19.53%) ⬆️

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1168a...b18aa9a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2026
View reviewed changes
test/python/adder.py

class AddableProtocol[T](Protocol):
"""Typer bound for any types that can be added."""
def __add__(self, other: T) -> T: ... # noqa: D105

Check notice

Code scanning / CodeQL

Statement has no effect Note test

This statement has no effect.
Copilot AI mentioned this pull request Jan 12, 2026
Merged
Copilot AI added a commit to greenc-FNAL/phlex that referenced this pull request Jan 12, 2026
@greenc-FNAL
Add Variant helper and address review comments
846c15f 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 12, 2026
@greenc-FNAL
Merge pull request #6 from greenc-FNAL/copilot/implement-variant-help…
885a947 
…er-in-pull-213

Integrate Variant helper from PR Framework-R-D#245 for type-specific Python algorithm registration
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 12, 2026
@greenc-FNAL
Add Variant helper and address review comments
ccee2ed 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 13, 2026
@greenc-FNAL
Add Variant helper and address review comments
d418fa1 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 13, 2026
@greenc-FNAL
Add Variant helper and address review comments
fc628d9 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 14, 2026
@greenc-FNAL
Add Variant helper and address review comments
6642d9a 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 14, 2026
@greenc-FNAL
Add Variant helper and address review comments
c37b752 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 14, 2026
@greenc-FNAL
Add Variant helper and address review comments
27c595b 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 20, 2026
@greenc-FNAL
Add Variant helper and address review comments
d3bd321 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 28, 2026
@greenc-FNAL
Add Variant helper and address review comments
7885af4 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 28, 2026
@greenc-FNAL
Add Variant helper and address review comments
2c73d29 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 28, 2026
@greenc-FNAL
Add Variant helper and address review comments
5ae06cb 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 29, 2026
@greenc-FNAL
Add Variant helper and address review comments
d3f0e5b 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Jan 31, 2026
@greenc-FNAL
Add Variant helper and address review comments
68625ea 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Feb 3, 2026
@greenc-FNAL
Add Variant helper and address review comments
c2c6690 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Feb 3, 2026
@greenc-FNAL
Add Variant helper and address review comments
c78727b 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Feb 9, 2026
@greenc-FNAL
Add Variant helper and address review comments
8ffb14d 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Feb 10, 2026
@greenc-FNAL
Add Variant helper and address review comments
720ab27 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Feb 10, 2026
@greenc-FNAL
Add Variant helper and address review comments
80f1ef4 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
greenc-FNAL added a commit to greenc-FNAL/phlex that referenced this pull request Feb 10, 2026
@greenc-FNAL
Add Variant helper and address review comments
caee90e 
- Added variant.py helper from PR Framework-R-D#245
- Modified modulewrap.cpp to recognize Variant wrapper via phlex_callable
- Updated adder.py to use Variant helper for type-specific registration
- Removed debug print statements from verify_extended.py
- Removed commented-out mutex code from modulewrap.cpp
- Removed debug message() calls from CMakeLists.txt
- Fixed LaTeX syntax in copilot-instructions.md (use Unicode ↔)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wlav