Skip to content

provide Python support for new product api#369

Open
wlav wants to merge 9 commits intoFramework-R-D:mainfrom
wlav:new-product-query-api
Open

provide Python support for new product api#369
wlav wants to merge 9 commits intoFramework-R-D:mainfrom
wlav:new-product-query-api

Conversation

@wlav
Copy link
Contributor

@wlav wlav commented Feb 26, 2026

This re-enables Python after adding support for the new product query API (#267). Note that there are a few more things added into the mix, that fit here:

  • Added support for different layers (prior, the layer was hard-wired and everything happened in either "job" or "event"). This goes along because the new product query makes the layer explicit, allowing for straightforward specification in the configuration.
  • Added support for JSON objects in the configuration wrapping. This to support the above.
  • Removal of code duplication introduced by Improve test coverage for Python support #213. This fits here because the duplicated code would otherwise need to be updated to the new product query API, so its removal shrinks the amount of refactoring needed.
  • Updates for test coverage; somewhat unrelated but the removal of duplicated code that was tested drops the overall ratio. This corrects some of that.

@wlav
Copy link
Contributor Author

wlav commented Feb 26, 2026

@phlexbot format

@github-actions
Copy link
Contributor

No automatic jsonnetfmt fixes were necessary.

@github-actions
Copy link
Contributor

No automatic markdownlint fixes were necessary.

@github-actions
Copy link
Contributor

No automatic cmake-format fixes were necessary.

@github-actions
Copy link
Contributor

No automatic clang-format fixes were necessary.

@wlav wlav requested a review from beojan February 26, 2026 19:54
@greenc-FNAL
Copy link
Contributor

Review the full CodeQL report for details.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 69 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/python/src/modulewrap.cpp 71.04% 38 Missing and 26 partials ⚠️
plugins/python/src/configwrap.cpp 83.33% 3 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (72.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   85.29%   82.70%   -2.59%     
==========================================
  Files         122      129       +7     
  Lines        2441     3262     +821     
  Branches      389      581     +192     
==========================================
+ Hits         2082     2698     +616     
- Misses        233      348     +115     
- Partials      126      216      +90     
Flag Coverage Δ
unittests 82.70% <72.72%> (-2.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/python/src/errorwrap.cpp 79.54% <ø> (ø)
plugins/python/src/pymodule.cpp 60.81% <100.00%> (ø)
plugins/python/src/wrap.hpp 100.00% <ø> (ø)
plugins/python/src/configwrap.cpp 85.56% <83.33%> (ø)
plugins/python/src/modulewrap.cpp 71.30% <71.04%> (ø)

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c7918...ae36af8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants