Skip to content

Simplify specification of product-query fields#373

Open
knoepfel wants to merge 1 commit intoFramework-R-D:mainfrom
knoepfel:simplify-product-query-spec
Open

Simplify specification of product-query fields#373
knoepfel wants to merge 1 commit intoFramework-R-D:mainfrom
knoepfel:simplify-product-query-spec

Conversation

@knoepfel
Copy link
Member

This enables a product_query specification like:

-    .input_family(product_query{.creator = "input"_id, .layer = "event"_id, .suffix = "id"_id})
+    .input_family(product_query{.creator = "input", .layer = "event", .suffix = "id"})

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   85.36%   85.22%   -0.15%     
==========================================
  Files         122      122              
  Lines        2433     2430       -3     
  Branches      389      388       -1     
==========================================
- Hits         2077     2071       -6     
+ Misses        233      232       -1     
- Partials      123      127       +4     
Flag Coverage Δ
unittests 85.22% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/product_query.hpp 90.00% <100.00%> (-2.86%) ⬇️
phlex/model/identifier.cpp 94.44% <100.00%> (+0.32%) ⬆️
phlex/model/identifier.hpp 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1dd203...0287787. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant