Draft
Conversation
- Checks run:
- `clang-analyzer-security-*`
- `bugprone-unsafe-functions`
- `concurrency-mt-unsafe`
```console
[310/437] Building CXX object phlex/app/CMakeFiles/run_phlex.dir/load_module.cpp.o
/phlex-src/phlex/app/load_module.cpp:32:37: warning: function is not thread safe [concurrency-mt-unsafe]
32 | char const* plugin_path_ptr = std::getenv("PHLEX_PLUGIN_PATH");
| ^
[332/437] Building CXX object test/CMakeFiles/hierarchical_nodes.dir/hierarchical_nodes.cpp.o
/phlex-src/test/hierarchical_nodes.cpp:70:26: warning: function is not thread safe [concurrency-mt-unsafe]
70 | std::strncpy(buffer, std::ctime(&tm), 26);
| ^
[344/437] Building CXX object test/form/CMakeFiles/WriteVector.dir/toy_tracker.cpp.o
/phlex-src/test/form/toy_tracker.cpp:22:15: warning: function is not thread safe [concurrency-mt-unsafe]
22 | int rand1 = rand() % 32768;
| ^
/phlex-src/test/form/toy_tracker.cpp:23:15: warning: function is not thread safe [concurrency-mt-unsafe]
23 | int rand2 = rand() % 32768;
| ^
[364/437] Building CXX object test/form/CMakeFiles/WriteVector.dir/writer.cpp.o
/phlex-src/test/form/writer.cpp:23:15: warning: function is not thread safe [concurrency-mt-unsafe]
23 | int rand1 = rand() % 32768;
| ^
/phlex-src/test/form/writer.cpp:24:15: warning: function is not thread safe [concurrency-mt-unsafe]
24 | int rand2 = rand() % 32768;
| ^
/phlex-src/test/form/writer.cpp:27:17: warning: function is not thread safe [concurrency-mt-unsafe]
27 | int rand1 = rand() % 32768;
| ^
/phlex-src/test/form/writer.cpp:28:17: warning: function is not thread safe [concurrency-mt-unsafe]
28 | int rand2 = rand() % 32768;
| ^
```
No automatic fixes
greenc-FNAL
changed the title
clang-tidy safety/security reports
- Surgical suppression of each check after verification.
Contributor
Author
|
@phlexbot clang-fix |
Contributor
|
Automatic clang-format fixes pushed (commit 19ef651). |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 85.36% 85.25% -0.12%
==========================================
Files 122 122
Lines 2433 2434 +1
Branches 389 389
==========================================
- Hits 2077 2075 -2
Misses 233 233
- Partials 123 126 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugprone-unsafe-functionsclang-analyzer-core.BitwiseShiftclang-analyzer-core.CallAndMessageclang-analyzer-core.CallAndMessageModelingclang-analyzer-core.DereferenceModelingclang-analyzer-core.DivideZeroclang-analyzer-core.DynamicTypePropagationclang-analyzer-core.FixedAddressDereferenceclang-analyzer-core.NonNullParamCheckerclang-analyzer-core.NonnilStringConstantsclang-analyzer-core.NullDereferenceclang-analyzer-core.StackAddrEscapeBaseclang-analyzer-core.StackAddressEscapeclang-analyzer-core.UndefinedBinaryOperatorResultclang-analyzer-core.VLASizeclang-analyzer-core.builtin.AssumeModelingclang-analyzer-core.builtin.BuiltinFunctionsclang-analyzer-core.builtin.NoReturnFunctionsclang-analyzer-core.uninitialized.ArraySubscriptclang-analyzer-core.uninitialized.Assignclang-analyzer-core.uninitialized.Branchclang-analyzer-core.uninitialized.CapturedBlockVariableclang-analyzer-core.uninitialized.NewArraySizeclang-analyzer-core.uninitialized.UndefReturnclang-analyzer-security.ArrayBoundclang-analyzer-security.FloatLoopCounterclang-analyzer-security.MmapWriteExecclang-analyzer-security.PointerSubclang-analyzer-security.PutenvStackArrayclang-analyzer-security.SetgidSetuidOrderclang-analyzer-security.cert.env.InvalidPtrclang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandlingclang-analyzer-security.insecureAPI.SecuritySyntaxCheckerclang-analyzer-security.insecureAPI.UncheckedReturnclang-analyzer-security.insecureAPI.bcmpclang-analyzer-security.insecureAPI.bcopyclang-analyzer-security.insecureAPI.bzeroclang-analyzer-security.insecureAPI.decodeValueOfObjCTypeclang-analyzer-security.insecureAPI.getpwclang-analyzer-security.insecureAPI.getsclang-analyzer-security.insecureAPI.mkstempclang-analyzer-security.insecureAPI.mktempclang-analyzer-security.insecureAPI.randclang-analyzer-security.insecureAPI.strcpyclang-analyzer-security.insecureAPI.vforkconcurrency-mt-unsafeInitial report:
No automatic fixes available.