Add device revision to the ATA device structure - #78
Merged
Conversation
InvoxiPlayGames
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATA device structure currently stores the device model only. In addition, the
ATA inquiry modelprint statement for the DVD drive does not print the firmware revision (currently, it prints a random decimal value due to an extra %d with no matching arg).This PR adds
revto store the firmware revision of the ODD and HDD, populates that structure, and updates the printf statements to print the contents of the new struct. The extra %d has been removed.The following is an example of what the output looks like, HDD there is no difference and for the ODD the drive revision is now properly printed