[1.0.0] Add support for EXTERNAL SASL auth.#177
Merged
Conversation
ChadSikorra
force-pushed
the
upgrade/external-sasl
branch
2 times, most recently
from
c41a8b7 to
5193c59
Compare
ChadSikorra
force-pushed
the
upgrade/external-sasl
branch
from
5193c59 to
ac31e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
EXTERNALSASL auth. This way auth is supported via client certificates, which requires cert validation. This seems like it would be a common secure setup for apps / service accounts to avoid storing passwords in different spots. Supporting this required changes in thefreedsx/saslandfreedsx/socketlibraries.I also started to refactor the representation of the AuthzID to make it less awkward to work with. I will need to follow up to replace its other usage. This PR is already quite big though. So wanted to separate that effort from this feature.