Repository navigation
Conversation
Kanti
commented
Oct 5, 2026
| const isFocused = this.matches(':focus-within'); | ||
| if (!isFocused && storedValue?.trim() !== slot?.innerText?.trim()) { | ||
| // Unfocused innerText may be case-transformed; compare the raw model instead. | ||
| if (!isFocused && storedValue?.trim() !== this.value.trim()) { |
Contributor
Author
There was a problem hiding this comment.
Potential Bug because we do not use the live value here.
Need to test this really good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing text styled with
text-transformcould store the rendered case instead of the original value. For example, editingStraßebeneath an uppercase heading could saveSTRASSEand count the transformed text against the field’s maximum length.Show the raw text while editing using
.slot:focusand a synchronous.slot.editingclass. Keep that class active until blur finishes reading, validating, and storing the text, then restore the frontend’s case transformation. Cancel pending caret work when the slot has lost focus and compare unfocused store changes against the raw value model. This removes the DOM-reading helper and its temporary inline-style mutations.Keep the Playwright test setup and run real component regressions in CI through
./Build/Scripts/runTests.sh -s playwright. The runner uses the pinned official Playwright container with Docker or Podman, preserving hostnode_modules; the localnpm run test:browseralternative remains available aftercomposer install. Browser checks load the actual component and store with TYPO3’s translation helper and bundled Lit directly from Composer-installed dependencies. The copied fixture and npm Lit dependency are removed. Separate CI jobs resolve and test TYPO3 13 and 14, including each version’s actual browser dependencies. The container command installs missing Composer dependencies automatically.Validation: ESLint, 73 Node tests, and 20 browser regressions passed locally. Browser coverage includes inherited uppercase/lowercase/capitalize, inline editors, Unicode, multiline/whitespace handling, immediate focus/blur, focus callback races, store/save/reset synchronization, style mutations, and real selections. Negative controls independently reproduced failures when removing the blur styling, focus callback guard, or raw-model comparison.
Refs #132.