-
Notifications
You must be signed in to change notification settings - Fork 794
Pulling in latest fhlmi and prek
#1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependencies to resolve CI failures by upgrading fhlmi from 0.40.1 to 0.41.0 and adding a version constraint for prek (<0.2.15).
- Updated
fhlmito 0.41.0 to use the newget_router()API method - Added defensive None-handling for token counts in response processing
- Added version constraint
prek<0.2.15to avoid issues with newer versions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated fhlmi dependency to >=0.41.0 and added prek version constraint <0.2.15 |
| src/paperqa/settings.py | Updated API call from router() to get_router() to match new fhlmi interface |
| src/paperqa/types.py | Added None-coalescing for prompt_count and completion_count to handle cases where these values might be None |
| tests/test_paperqa.py | Added explicit None checks before asserting token counts are positive to align with defensive coding in types.py |
| uv.lock | Updated package lock file with new versions and dependency markers for fhlmi 0.41.0, platform-specific markers for various nvidia/pyobjc packages, and opencv-python-headless |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jabra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
07a9e6f to
59e6369
Compare
… using litellm.completion_cost
Getting CI to pass again after Future-House/ldp#369 and j178/prek#1104
Also working around mwouts/jupytext#1467 better after more updates