Skip to content

Conversation

@jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Nov 17, 2025

Getting CI to pass again after Future-House/ldp#369 and j178/prek#1104

Also working around mwouts/jupytext#1467 better after more updates

@jamesbraza jamesbraza self-assigned this Nov 17, 2025
Copilot AI review requested due to automatic review settings November 17, 2025 22:54
@jamesbraza jamesbraza added the bug Something isn't working label Nov 17, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 17, 2025
@dosubot
Copy link

dosubot bot commented Nov 17, 2025

Related Documentation

Checked 1 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Copilot finished reviewing on behalf of jamesbraza November 17, 2025 22:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies to resolve CI failures by upgrading fhlmi from 0.40.1 to 0.41.0 and adding a version constraint for prek (<0.2.15).

  • Updated fhlmi to 0.41.0 to use the new get_router() API method
  • Added defensive None-handling for token counts in response processing
  • Added version constraint prek<0.2.15 to avoid issues with newer versions

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Updated fhlmi dependency to >=0.41.0 and added prek version constraint <0.2.15
src/paperqa/settings.py Updated API call from router() to get_router() to match new fhlmi interface
src/paperqa/types.py Added None-coalescing for prompt_count and completion_count to handle cases where these values might be None
tests/test_paperqa.py Added explicit None checks before asserting token counts are positive to align with defensive coding in types.py
uv.lock Updated package lock file with new versions and dependency markers for fhlmi 0.41.0, platform-specific markers for various nvidia/pyobjc packages, and opencv-python-headless

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@jabra jabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 17, 2025
@jamesbraza jamesbraza merged commit 11a6322 into main Nov 18, 2025
12 of 14 checks passed
@jamesbraza jamesbraza deleted the passing-ci branch November 18, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants