feat: Add single phase viscosity dependency on temperature#4029
Open
feat: Add single phase viscosity dependency on temperature#4029
Conversation
dkachuma
requested review from
OmarDuran,
castelletto1,
herve-gross,
jhuang2601 and
rrsettgast
as code owners
dkachuma
added
type: feature
herve-gross
approved these changes
Apr 14, 2026
jhuang2601
approved these changes
Apr 15, 2026
jhuang2601
approved these changes
Apr 15, 2026
Co-authored-by: Jian Huang <53012159+jhuang2601@users.noreply.github.com>
…uid.rst Co-authored-by: Jian Huang <53012159+jhuang2601@users.noreply.github.com>
castelletto1
approved these changes
Apr 29, 2026
| This model represents a compressible single-phase fluid with constant compressibility | ||
| and pressure-dependent viscosity. | ||
| For thermal simulations, the model density and viscosity have a temperature dependency | ||
| expressed as a constant thermal expansion coefficient. |
Collaborator
There was a problem hiding this comment.
Suggested change
| expressed as a constant thermal expansion coefficient. | |
| expressed as a constant thermal expansion coefficient and a constant temperature-viscosity coefficient, respectively. |
Comment on lines
+257
to
+258
| /// scalar fluid viscosity thermal expansion coefficient | ||
| real64 m_viscosityExpansivity; |
Collaborator
There was a problem hiding this comment.
Are fluid viscosity thermal expansion coefficient and viscosity expansivity standard nomenclature for fractional change in viscosity with respect to temperature?
Suggested change
| /// scalar fluid viscosity thermal expansion coefficient | |
| real64 m_viscosityExpansivity; | |
| /// scalar fluid temperature-viscosity coefficient | |
| real64 m_temperatureViscosityCoefficient; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a viscosity thermal expansion coefficient for single phase fluid. This introduces a simple dependency of the viscosity on temperature.
The documentation has been updated to reflect this addition.
Replaces #3951