-
Notifications
You must be signed in to change notification settings - Fork 54
Refactoring with scripts and stream commands help #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…r commands enums.
…tion vector for 2D scalar data.
camierjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Tried down to the emscriptem & JS: looks good!
|
@najlkin, can you resolve the conflicts? |
|
There was just the patch #343 , which is not needed here as the data structure is redesigned here, so just an empty commit 😉 . |
|
Mention in |
tzanio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @najlkin !
|
@justinlaughlin and @v-dobrev -- do you want to take a look? |
Refactored the code base, separating scripts handling and introducing a help for script commands (which can be placed on the website too). At the moment it is:
Similarly, handling of stream commands has been refactored, offering the following help:
🌟 Besides there are multiple other improvements:
Windowstructure bundling (some of) the shared objects, eliminating the global state. This is a lightweight version of Refactoring to remove global state #170 .GetAppWindow()(a global function for obtaining thread-localSdlWindow)GLVisInitVis()anddisplay()inaux_js.cpp.StreamReader) and improvedDataState, so all data types can be animated 🎞️ .✔️ Tests: