Increased TSM-buffer size to 16 MiB #27
Merged
+33
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianTackeGSI
approved these changes
Oct 23, 2025
Member
ChristianTackeGSI
left a comment
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
Looks good for now. :-)
I assume this was tested somewhat?
Member
ChristianTackeGSI
left a comment
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
This looks good now!
We're at 8 commits. Please consider a rebase / squash / etc. and combine things into fewer commits?
TBH I don't know, what would be a good granularity, because after all its still only increasing and switching to malloc. All the rest is closely related cleanup / error checking, etc.
lowBudgetHypothermia
force-pushed
the
increase_tsm_buffersize
branch
from
f37ffb7 to
fa47510
Compare
The TSM-buffer size was increased to 16 MiB. As a consquence of this the TSM buffer has to be allocated on the heap for ltsmc.c and common.c to prevent segmentation faults. A condition was added in function crc32file() for setting crc32result.
lowBudgetHypothermia
force-pushed
the
increase_tsm_buffersize
branch
from
fa47510 to
303cfeb
Compare
ChristianTackeGSI
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TSM-buffer size was increased to 16 MiB. As a consquence of this the TSM buffer has to be allocated on the heap for ltsmc.c and common.c to prevent segmentation faults.