Fix no mic input after CAT command#30
Open
m0kct wants to merge 56 commits into
Open
Conversation
As per https://github.com/threeme3/usdx, commit ab41ebbc3b3 by SQ5BPF.
As per https://github.com/threeme3/usdx, commit 63fb397ee
…, or save automatically (old behaviour)
This reverts commit 750ed94.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my white buttons uSDX+, the mic input stopped working after any CAT command (more precisely, after the first semicolon on serial, which set cat_active = 1). Without CAT, it worked fine. With CAT, I got noise and a vague sinewave on MOX, instead of what was being fed into the mic input.
I have successfully made FT8 QSOs with this patch, whereas before this was impossible (with CAT enabled).
I don't pretend to fully understand what's going on here, but I believe the issue was that the LCD code did not correctly reset the state of PC2 to allow ADC2 to be used for mic input.
What I fail to understand is why nobody else seems to be reporting this problem ...