Fixed "Trying to access array offset on value of type null" in Random…#83
Open
srijaydeathwish wants to merge 1 commit intoGargron:masterfrom
Open
Fixed "Trying to access array offset on value of type null" in Random…#83srijaydeathwish wants to merge 1 commit intoGargron:masterfrom
srijaydeathwish wants to merge 1 commit intoGargron:masterfrom
Conversation
editionslva
suggested changes
Jul 21, 2022
editionslva
left a comment
editionslva
left a comment
There was a problem hiding this comment.
You'd better test isset($content_range[1]) and not just if array is empty, I suppose.
That 's possible if $SERVER['HTTP_CONTENT_RANGE'] is defined but void then preg_split will return an array with only one element.
After that, if $uploaded_bytes is not defined you could also have a notice on line 75 . That' why I propose if (isset($content_range[1]) {...} else { $uploaded_bytes = '';} or maybe better include the next while in the if statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed "Trying to access array offset on value of type null in FileUpload\FileNameGenerator\Random.php" with simple not empty check on "content_range[1]" variable.