-
Notifications
You must be signed in to change notification settings - Fork 6
feat: new query parse endpoint #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fengelniederhammer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing an e2e test (one test that sends a complex valid query and an invalid one might be enough). Otherwise this looks good!
lapis/src/main/kotlin/org/genspectrum/lapis/model/QueryParseModel.kt
Outdated
Show resolved
Hide resolved
lapis/src/main/kotlin/org/genspectrum/lapis/openApi/OpenApiDocs.kt
Outdated
Show resolved
Hide resolved
lapis/src/test/kotlin/org/genspectrum/lapis/controller/QueryControllerTest.kt
Outdated
Show resolved
Hide resolved
lapis/src/test/kotlin/org/genspectrum/lapis/controller/QueryControllerTest.kt
Outdated
Show resolved
Hide resolved
lapis/src/test/kotlin/org/genspectrum/lapis/controller/QueryControllerTest.kt
Show resolved
Hide resolved
|
Let's also add something to the LAPIS docs. Maybe a paragraph on the advanced queries page that tells the user that there is an endpoint to validate them? |
|
I addressed all the comments, added an e2e test and added docs. You can have another look! |
resolves #1518
Adds a new
/query/parseendpoint where you can pass a list of strings (in a POST request) to be parsed. The response is also a list, with either afilteror anerror.Screenshot
Swagger UI with new controller:
Example
request:
response:
PR Checklist