feat(lapis): support filename* with UTF-8 character encoding
#1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom RFC 5987 encoding with Spring's built-in ContentDisposition builder. This reduces maintenance burden by leveraging Spring's well-tested implementation while adding dual parameter support (filename= and filename*=) for maximum browser compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The plain filename= parameter now contains only ASCII characters (code < 128) for maximum compatibility with legacy systems. Non-ASCII characters are removed entirely. The filename*= parameter continues to provide full UTF-8 support via RFC 5987 encoding. Examples: - données.json → filename=donnes.json; filename*=UTF-8''donn%C3%A9es.json - 测试.json → filename=.json; filename*=UTF-8''%E6%B5%8B%E8%AF%95.json 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fhennig
changed the title
filename* with UTF-8 character encoding
fhennig
force-pushed
the
feat/spring-content-disposition
branch
from
3e97b88 to
b9b3ea8
Compare
Extract duplicated Content-Disposition generation logic from DownloadAsFileFilter and LapisControllerDownloadAsFileTest into a shared utility (ContentDispositionUtils.kt). This eliminates ~30 lines of code duplication and provides a single source of truth for filename encoding. Changes: - Add ContentDispositionUtils.kt with generateContentDisposition() and toAsciiFilename() - Add ContentDispositionUtilsTest.kt with comprehensive test coverage - Refactor DownloadAsFileFilter.kt to use utility (15 lines → 3 lines) - Refactor LapisControllerDownloadAsFileTest.kt to use utility (19 lines → 3 lines) - Remove unused imports from both files Benefits: - Single source of truth for Content-Disposition logic - Easier maintenance (changes in one place) - Better testability (utility tested independently) - Cleaner code structure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
fhennig
force-pushed
the
feat/spring-content-disposition
branch
from
b9b3ea8 to
fe8e4cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1494
ContentDispositionclass to generate the correctfilename*headerfilenameheader (See also ContentDisposition should allow encoding filename and filename* with different strategies and encodings spring-projects/spring-framework#31940 - TheContentDispositionclass will encodefilenameas well, we do not want that because not all clients will decode headers)PR Checklist