Skip to content

Fix #2532 update submodule and improve style#2541

Merged
allyoucanmap merged 1 commit into
GeoNode:masterfrom
allyoucanmap:issue_2532_2
May 25, 2026
Merged

Fix #2532 update submodule and improve style#2541
allyoucanmap merged 1 commit into
GeoNode:masterfrom
allyoucanmap:issue_2532_2

Conversation

@allyoucanmap
Copy link
Copy Markdown

This PR introduces following fixes:

@allyoucanmap allyoucanmap added this to the 5.2.0 milestone May 22, 2026
@allyoucanmap allyoucanmap requested a review from dsuren1 May 22, 2026 16:47
@allyoucanmap allyoucanmap added the bug Something isn't working label May 22, 2026
@allyoucanmap allyoucanmap linked an issue May 22, 2026 that may be closed by this pull request
3 tasks
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MapStore2 submodule and expands the .gitignore file to include various AI tool configurations. It also removes catalogue service setup logic from the Django application configuration and deletes a significant number of LESS variable definitions and style overrides. A critical issue was identified regarding the removal of the @font-size-sm variable, which is still referenced in other theme files and will likely cause LESS compilation errors.


// alias
@font-size-lg: @font-size-large;
@font-size-sm: @font-size-small;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The variable @font-size-sm is used in geonode_mapstore_client/client/themes/geonode/less/ms-theme.less (line 242), but its definition is being removed here. Since @font-size-sm is not a standard Bootstrap 3 variable (it was defined here as an alias to @font-size-small), removing it will likely cause a LESS compilation error unless the updated MapStore submodule now provides it natively. If it is not provided by the base theme, this alias should be retained or the usage in ms-theme.less should be updated to @font-size-small.

@allyoucanmap allyoucanmap merged commit 5a44df1 into GeoNode:master May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace of DatasetCatalog with the new Catalog

2 participants