Fix #2532 update submodule and improve style#2541
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the MapStore2 submodule and expands the .gitignore file to include various AI tool configurations. It also removes catalogue service setup logic from the Django application configuration and deletes a significant number of LESS variable definitions and style overrides. A critical issue was identified regarding the removal of the @font-size-sm variable, which is still referenced in other theme files and will likely cause LESS compilation errors.
|
|
||
| // alias | ||
| @font-size-lg: @font-size-large; | ||
| @font-size-sm: @font-size-small; |
There was a problem hiding this comment.
The variable @font-size-sm is used in geonode_mapstore_client/client/themes/geonode/less/ms-theme.less (line 242), but its definition is being removed here. Since @font-size-sm is not a standard Bootstrap 3 variable (it was defined here as an alias to @font-size-small), removing it will likely cause a LESS compilation error unless the updated MapStore submodule now provides it natively. If it is not provided by the base theme, this alias should be retained or the usage in ms-theme.less should be updated to @font-size-small.
This PR introduces following fixes: