Open
Conversation
…ionApi.startNotificationTimeout
|
Size Change: +1.05 kB (+0.17%) Total Size: 615 kB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Summary
This PR introduces a new notifications facade hook:
useNotificationApiat src/components/Notifications/hooks/useNotificationApi.ts, and migrates notification API usage insrcto use it.What changed
useNotificationApi(): NotificationApi.AddNotificationParamsNotificationIncidentDescriptorAddNotificationRemoveNotificationStartNotificationTimeoutNotificationApiaddNotificationabstraction overclient.notifications.addmessage,emitter,severity,duration,actions,error,context,tags,targetPanels,type,incident.useNotificationTargetby default.targetPanels(including multiple panels).targetPanelsare provided, inferred panel is ignored.typeas-is.typeis omitted andincidentis provided, type is generated from incident descriptor.typeis provided,incidentis optional and not required.removeNotification(id)delegates toclient.notifications.remove(id).startNotificationTimeout(id)delegates toclient.notifications.startTimeout(id).client.notificationspublish calls insrcwithuseNotificationApi().addNotification.IconMinuscomponent and used it inNumericInputWhy
client.notificationsacross components.Tests
useNotificationApibehavior (including target panel handling and type generation).NotificationList.