Conversation
|
@aagear is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Protocol Buffers generated file suffixes for Python and Ruby to
GENERATED_FILE_SUFFIXES, closing a gap where Go (.pb.go), TypeScript (.pb.ts,_pb.d.ts), JavaScript (.pb.js,_pb.js), and Dart (.g.dart) were covered but Python and Ruby were not.Changes
packages/diff-filter/src/patterns.ts: Added 4 suffixes toGENERATED_FILE_SUFFIXES:_pb2.py— Python protoc message classes_pb2.pyi— Python type stubs_pb2_grpc.py— Python gRPC stubs_pb.rb— Ruby protoc message classespackages/diff-filter/tests/classify.test.ts: Added 4 test cases covering nested paths and all new suffixes. Also addedreason: "generated_suffix"assertion to the existing generated suffix tests for consistency.Testing
All tests pass — the diff-filter test suite covers lockfiles, binaries, generated dirs, generated suffixes (now including Python/Ruby protobuf), custom globs, real-code preservation, Windows paths, and edge cases.
Fixes #154