Add replaceable Chinese Skill variant - #38
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe PR adds English and Chinese ChangesRouter Skill variants
Estimated code review effort: 3 (Moderate) | ~30 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GhostXia
changed the title
GhostXia
marked this pull request as ready for review
August 12, 2026 05:35
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/zh-CN/README.md`:
- Around line 136-137: 更新 docs/zh-CN/README.md 中相邻的 CI 语言规则说明，使其准确反映
scripts/validate_repo.py 的行为：非 ASCII 检查不适用于
.agents/skills/lean-dev-router/SKILL.md，而不是声称所有 .agents/ 文件都会被拦截。
In `@README.md`:
- Around line 304-307: Separate the Chinese replacement and English restoration
commands into distinct, clearly labeled blocks in README.md lines 304-307 and
docs/zh-CN/README.md lines 112-115, so users can run the Chinese command for
testing without immediately executing the restoration command.
In `@skill-variants/en/SKILL.md`:
- Around line 129-134: Clarify the revision fingerprint wording in
skill-variants/en/SKILL.md lines 129-134 by stating that all authorized tracked
diffs, including text and binary changes using Git’s binary-safe encoding, are
included. Apply the equivalent clarification in skill-variants/zhcn/SKILL.md
line 104, replacing “tracked binary diff” with wording covering both tracked
text and binary diffs.
- Around line 199-205: Update the repair-packet documentation in
skill-variants/en/SKILL.md lines 199-205 to include PLAN_ID, REPAIR_CYCLE,
REVISION, and EVIDENCE_FINGERPRINT alongside the existing identity, acceptance,
affected-path, and evidence fields. Update skill-variants/zhcn/SKILL.md lines
133-134 with the same required fields, or reference the exact runtime-guard
schema; ensure both variants fully document the packet consumed by the runtime
guard.
In `@skill-variants/zhcn/SKILL.md`:
- Around line 112-114: 将中文版本中“技术证据不足时请求 planning_resolution”改为请求
technical_resolution，使其与英文版本及路由表保持一致；保留 planning_resolution 仅用于 Terra 向 Sol
升级规划问题的语义。
- Line 8: 更新该中文 Skill 的代理职责描述，移除“Terra 审计并解决技术问题”中的修复权限，明确 Terra
仅可提供因果证据和有界修复建议；保留 Sol 的规划授权、父代理的机械调度以及 Luna 的写入职责，并与第 19、135 行的只读约束一致。
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 669baa99-299f-478e-935e-f4609af6742c
📒 Files selected for processing (6)
README.mddocs/zh-CN/README.mdscripts/validate_repo.pyskill-variants/en/SKILL.mdskill-variants/zhcn/SKILL.mdtests/test_validate_repo.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agents/skills/lean-dev-router/SKILL.mdbyte-identical to the current EnglishmainSkillskill-variants/en/SKILL.mdas the exact English restore copyskill-variants/zhcn/SKILL.mdas the compact Chinese test variantLocal replacement
Enable the Chinese test variant:
Restore the English release default:
Start a fresh Codex task after either replacement.
Static compression
The regex word count is a repository budget metric, not a model-token measurement.
Real-context forward test
Two counterbalanced pairs of fresh subagents (
fork_turns: none) read one variant each and answered the same eight routing scenarios. Actualtoken_countevents were used instead of character or regex-word estimates.The second call is the first model request containing the loaded Skill. Server cache hits varied, so the comparison uses full input-context tokens, not uncached billing tokens. Launch order reversed between pairs and produced the same direction.
Both variants made the correct authority, revision, repair, scope-escalation, spinning-fuse, and abandoned-audit decisions in all eight cases. A fresh blind judge found no material semantic difference; the Chinese sample was slightly more explicit in two answers, but not behaviorally different.
Decision: retain English as the release default. Chinese did not satisfy the switch criterion of equal-or-better quality and lower measured real-context input usage. It remains available as the replaceable test variant.
Validation
python -B -m unittest discover -s tests- 59 passed, 1 skipped on Windowspython -B scripts/validate_repo.py- passedquick_validate.py- root, English, and Chinese variants passed under UTF-8 modegit diff --check- passedorigin/mainSkill have the same Git blob hash