Optimize bilingual contracts and add runtime preflight - #41
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (42)
📝 WalkthroughWalkthroughThe pull request adds deterministic revision and dispatch preflight validation, integrates preflight into ChangesRuntime preflight and Skill validation
Issue 40 routing evaluation
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Evaluator
participant run_issue40_short_test_cli.py
participant Codex
participant ExperimentManifest
Evaluator->>run_issue40_short_test_cli.py: select matrix and worker count
run_issue40_short_test_cli.py->>Codex: execute read-only routing prompt
Codex-->>run_issue40_short_test_cli.py: output, session ID, and status
run_issue40_short_test_cli.py->>ExperimentManifest: write run metadata and logs
Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue #40 短程测试结果(实验门禁,PR #41)1. 实验设置
可复现材料:
2. CLI 控制批 token 结果(读 Skill 后首次调用,每格中位数)
3. 效应分解(CLI 控制批,输入 token 中位数差异)
未缓存输入(Skill 内容新增 token)同样显示去重收益:E1 比 E0 少约 650–690,C1 比 C0 少约 720–730;优化后中文仍比优化后英文多约 120–170。 4. 质量门
5. 短程结论
6. 尚未完成
|
Summary
E1) and Chinese (C1) Skill variants while leaving the release-defaultE0and testC0untouchedpreflightCLI that shares one deterministic dispatch decision with productionstartRuntime behavior
preflight: validates a JSON dispatch without creating state; intended for templates and installed-runtime checksstart: performs the same preflight and initializes guard state atomically; normal scheduling still uses one command, notpreflightplusstartinvalid_dispatch, errors, destination, and dispatch fingerprintinvalid_inputBASELINEmust be 40/64 lowercase Git hexREVISIONmust equalBASELINEor beworktree-sha256:<64 lowercase hex>Static contract reduction
E1 is 11.8% smaller than E0; C1 is 14.0% smaller than C0. E1/C1 have identical line-level Markdown structure signatures. English remains the release default.
Self-audit findings fixed
preflightandstartinvalid-dispatch reason/errors/fingerprint through one decision functionValidation
python -B -m unittest discover -s tests- 65 passed, 1 skipped on Windowspython -B scripts/validate_repo.py- passedquick_validate.py- root, E1, and C1 passedschemaandpreflightsmoke - passedpreflight/startfingerprint equality smoke - passedgit diff --check- passedskill-variants/en/SKILL.mdRemaining experimental work
Implementation, self-audit, deterministic tests, and the short-context E0/C0/E1/C1 matrix are complete. This PR adds E1/C1 as non-default candidates and does not change the release-default E0. The 100k+ E1/C1 comparison and complete raw-session evidence remain open in #40 and are required before any default switch.
Refs #40
Summary by CodeRabbit
New Features
Documentation
Tests
Experiments