Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Split out forks into their own classes - #28

Merged
Glennmen merged 21 commits into
Glennmen:masterfrom
CalamityJames:classes
Sep 18, 2017
Merged

Split out forks into their own classes#28
Glennmen merged 21 commits into
Glennmen:masterfrom
CalamityJames:classes

Conversation

@CalamityJames

@CalamityJames CalamityJames commented Sep 11, 2017

Copy link
Copy Markdown
Collaborator

Large rework of the way forks are handled, splitting out into their own classes.

This makes adding support for an extra fork much easier.

I have also converted #26 to work with the new class system, thanks go to @wateredstorm for his work on that :)

Forks tested:

  • Asner Monocle fork
  • Monkey Monocle fork
  • Sloppy RocketMap fork
  • Vanilla Monocle
  • Vanilla RocketMap

I am open to any suggestions or improvements for how we handle new classes, at the moment they are all loaded in an array in config/default.php

I have also merged in #13 to here, as it saves having multiple PRs open from me!

@baskettcase

baskettcase commented Sep 11, 2017

Copy link
Copy Markdown

I don't know if you'll want this, but this is a lib file for Asner's Monocle PR, not his fork.
Monocle_Asner.php.zip

Maybe this isn't Asner.. but it's for this Monocle PR: Noctem/Monocle#306

@beloware

Copy link
Copy Markdown

Now setup, yet monkey fork.

@ecology99

Copy link
Copy Markdown

With this new PR, with RM default I always get this error:
https://prntscr.com/gk0eqk

@cptmedic cptmedic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being picky, but for consistency (and because I know someone will eventually ask) in config.example.php from // default/asner/sloppy to // default/asner/sloppy/monkey

Thanks @captainmedic !
@CalamityJames

Copy link
Copy Markdown
Collaborator Author

@captainmedic Done, thanks for the suggestion!

@tobias86aa

Copy link
Copy Markdown

Sloppys fork seems to be working good.

@Demokdawa

Copy link
Copy Markdown

Works perfectly well with lastest commit :p

@cptmedic

Copy link
Copy Markdown
Contributor

Monkey branch works on CentOS 7. I have not test the discord include button as the discord is private, but everything else that I use is confirmed working on my instances

@Glennmen
Glennmen merged commit 96abaa2 into Glennmen:master Sep 18, 2017
@CalamityJames
CalamityJames deleted the classes branch September 21, 2017 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants