Skip to content

perf(web): deduplicar fetch de auth/notifications en AppBar (#277) #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgpastor merged 3 commits into from
Jul 6, 2026
Merged

perf(web): deduplicar fetch de auth/notifications en AppBar (#277) #349

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a222af
chore: gitignore .worktrees/ for local parallel dev worktrees
nopestack Jul 6, 2026
3c9ffc5
perf(web): deduplicar fetch de auth/notifications en AppBar (#277)
nopestack Jul 6, 2026
2f607c3
Merge remote-tracking branch 'origin/main' into merge-337
claude Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions apps/web/src/components/organisms/app-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import Link from 'next/link';
import { api } from '@/lib/api';
import { getToken, authHeaders, loginHref as buildLoginHref } from '@/lib/auth';
import { loginHref as buildLoginHref } from '@/lib/auth';
import { resolveAppBarCurrentPath } from '@/lib/app-bar-context';
import { getT } from '@/i18n/server';
import { getMe, getNotificationUnread } from '@/lib/navigation-data';
import { BrandLogo } from '@/components/molecules/brand-logo';
import { LanguageSwitcher } from '@/components/molecules/language-switcher';
import { AccountControl } from '@/components/molecules/account-control';
Expand Down Expand Up @@ -36,20 +36,14 @@ const STATUS_DOT: Record<'active' | 'paused' | 'closed', string> = {
export async function AppBar({ variant, slug, emergency, backHref, currentPath }: AppBarProps) {
const { t } = await getT();
const ta = t.appbar;
const token = await getToken();

let user: { name: string; email: string; isAdmin: boolean } | null = null;
let unreadCount = 0;
if (token != null) {
const [meRes, notifRes] = await Promise.all([
api.GET('/auth/me', { headers: authHeaders(token) }),
api.GET('/notifications/mine', { headers: authHeaders(token) }),
]);
if (meRes.data != null) {
user = { name: meRes.data.name, email: meRes.data.email, isAdmin: meRes.data.isAdmin === true };
}
if (notifRes.data != null) unreadCount = notifRes.data.unreadCount;
}

// getMe()/getNotificationUnread() are wrapped in React `cache()` (see
// navigation-data.ts), so this dedupes with any other consumer that reads
// the same principal/notifications data within this request instead of
// re-hitting /auth/me and /notifications/mine per page (#277).
const [me, unreadCount] = await Promise.all([getMe(), getNotificationUnread()]);
const user =
me != null ? { name: me.name, email: me.email, isAdmin: me.isAdmin === true } : null;

const loginHref = buildLoginHref(resolveAppBarCurrentPath(slug, currentPath));

Expand Down
Loading