Skip to content

Use Guava's ImmutableMap.of() instead of Map.of(). #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Use Guava's ImmutableMap.of() instead of Map.of(). #530

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12bfcee
Use Guava's ImmutableMap.of() instead of Map.of().
glennhartmann Jun 6, 2025
e0ce682
Merge branch 'main' into map-of-to-immutablemap-of
glennhartmann Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions androidbrowserhelper/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ dependencies {
implementation 'androidx.annotation:annotation:1.1.0'
implementation 'androidx.core:core:1.0.2'
implementation 'androidx.appcompat:appcompat:1.7.0'
implementation 'com.google.guava:guava:33.4.8-android'

testImplementation 'junit:junit:4.12'
testImplementation 'org.mockito:mockito-core:3.0.0'
Expand Down
4 changes: 3 additions & 1 deletion ...elper/src/main/java/com/google/androidbrowserhelper/trusted/LauncherActivityMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import java.util.List;
import java.util.Map;

import com.google.common.collect.ImmutableMap;

import static android.view.WindowManager.LayoutParams.LAYOUT_IN_DISPLAY_CUTOUT_MODE_DEFAULT;

/**
Expand Down Expand Up @@ -162,7 +164,7 @@ public class LauncherActivityMetadata {
private static final String LAUNCH_HANDLER_CLIENT_MODE_METADATA_NAME
= "android.support.customtabs.trusted.LAUNCH_HANDLER_CLIENT_MODE";
private static final Map<String, Integer> LAUNCH_HANDLER_CLIENT_MODE_MAP =
Map.of(
ImmutableMap.of(
"navigate-existing", LaunchHandlerClientMode.NAVIGATE_EXISTING,
"focus-existing", LaunchHandlerClientMode.FOCUS_EXISTING,
"navigate-new", LaunchHandlerClientMode.NAVIGATE_NEW,
Expand Down