Merge main into stable #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove package namespace definition in Manifest. Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported. 2. Specify an explicit value for `android:exported` when the component has an intent filter defined. 3. Add androidx.appcompat:appcompat build dependency in build.gradle 4. Complete the PwaWrapperSplashScreenStrategy()'s startChromeBeforeAnimationComplete argument in test
The default behavior is to not wait enter animation complete before starting twa in browser. The waitsForEnterAnimationCompletion_BeforeDeclaringReady test does not need to be kept.
Add package name constructor to TwaLauncher
Use Guava's ImmutableMap.of() instead of Map.of().
Skip animation as default
The skip animation as default PR(#520) changes behaviour of abh. Added the change description to changelog. Also, bump up the version & version code.
Bump abh VERSION to 2.6.2 and VERSION_CODE to 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this in order to import recent changes to internal Google repo.