Add edge-to-edge support for the splash screen #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splash screen uses deprecated APIs for setting status bar and navigation bar colors. This PR updates splash screen to use window insets and draw behind the system bars.
androidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/Utils.java
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...oidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/LauncherActivity.java
Outdated
Show resolved
Hide resolved
androidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/Utils.java
Show resolved
Hide resolved
androidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/Utils.java
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...oidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/LauncherActivity.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
androidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/Utils.java
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
| ImmutableList.of(statusBarProtection, navigationBarProtection)); | ||
| rootView.addView(protectionLayout); | ||
| protectionLayout.setVisibility(View.VISIBLE); | ||
| protectionLayout.setElevation(1f); |
Collaborator
Author
There was a problem hiding this comment.
The splash screen ImageView is added later to this FrameLayout and it draws views by recency, unless we set z-index manually
Collaborator
Author
There was a problem hiding this comment.
Removed manual elevation setting
| super.onCreate(savedInstanceState); | ||
|
|
||
| WindowCompat.enableEdgeToEdge(getWindow()); | ||
| getWindow().addFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_BACKGROUNDS); |
Collaborator
There was a problem hiding this comment.
I think it's better to move this to splash coordinator, otherwise we have a chance of getting obscured status bar icons.
Collaborator
Author
There was a problem hiding this comment.
As we discussed offline, status bar icons are not getting obscured
Collaborator
There was a problem hiding this comment.
With a fresh look, let's move it to the splash controller and apply when we definitely set a color to system bars.
Collaborator
Author
There was a problem hiding this comment.
In that case the bug that we have now with the behavior without the splash screen will not be fixed.
Right now the transparent activity without splash screen shows black system bars, instead of being transparent. Setting this flag fixes it.
Collaborator
|
@gstepniewski-google can you PTAL too? |
ukaratkevich
approved these changes
Oct 21, 2025
| super.onCreate(savedInstanceState); | ||
|
|
||
| WindowCompat.enableEdgeToEdge(getWindow()); | ||
| getWindow().addFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_BACKGROUNDS); |
Collaborator
There was a problem hiding this comment.
With a fresh look, let's move it to the splash controller and apply when we definitely set a color to system bars.
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/androidbrowserhelper/trusted/splashscreens/EdgeToEdgeController.java
Show resolved
Hide resolved
gstepniewski-google
approved these changes
Oct 21, 2025
Collaborator
gstepniewski-google
left a comment
gstepniewski-google
left a comment
There was a problem hiding this comment.
Thanks, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splash screen uses deprecated APIs for setting status bar and navigation bar colors. This PR updates splash screen to use window insets and draw behind the system bars.