Improve File Handling with Path Joins - #149
Open
Nitesh-thapliyal wants to merge 1 commit into
Open
Conversation
Member
|
This is unnecessary. The existing code works fine on Windows. |
Member
|
Although it’s unnecessary, I remember the previous discussion in #68 now, where I mentioned being open to a PR that does exactly this. Given that earlier promise, LGTM. |
mathiasbynens
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
path.jointo ensure cross-platform compatibility for file paths.Note:
I am currently using a Linux OS and could not test the installer on Windows. I recommend reviewing the changes carefully and running tests on a Windows environment to ensure proper functionality.