Add camera summary section #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@RReverser Please have a look. |
RReverser
reviewed
Feb 2, 2022
|
|
||
| val summary() { | ||
| return gpp_rethrow([=]() { | ||
| val result = val::object(); |
Collaborator
There was a problem hiding this comment.
Nit: I'd probably avoid the object and just return the string, converted to val, directly.
Collaborator
|
Left one nit above. Overall I think this serves as a good example of integrating other APIs, but I'm not sure we should show it in the UI because the "summary" text is pretty verbose on real cameras. Additionally, the most interesting information from the summary - camera model, serial number, etc. - is already exposed via individual fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a way for me to start playing with this cool demo. It adds a "Camera Summary" section at the bottom right of the web app to display information such as Manufacturer, Model, Version, Serial Number, Capture Formats,
Display Formats, Device Capabilities, Storage Devices Summary, etc.