Skip to content

Conversation

@derrickaw
Copy link
Contributor

  1. Updating existing template to use new design pattern with option files.
  2. Update example and language of kafka option file.
  3. Create BigQuery option file.

@gemini-code-assist
Copy link

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the KafkaToBigQuery YAML template by implementing a new design pattern that externalizes template parameter definitions into separate option files. This change aims to improve the organization and reusability of configuration options. It involves introducing a new file for BigQuery-specific options and enhancing the existing Kafka options file, while the core template is updated to seamlessly integrate these modularized parameter sets.

Highlights

  • New Design Pattern Adoption: The template now utilizes a new design pattern that separates parameter definitions into dedicated option files, enhancing modularity and reusability.
  • BigQuery Options File Created: A new bigquery_options.yaml file has been added, centralizing BigQuery-specific parameters such as table specification, creation disposition, write disposition, and the number of Storage Write API streams.
  • Kafka Options Refinement: The kafka_options.yaml file has been updated with a more comprehensive example for bootstrapServers and clarified help text for the schema parameter, specifying its requirement for certain data formats.
  • KafkaToBigQuery Template Streamlined: The main KafkaToBigQuery.yaml template has been refactored to import and reference parameters from the new kafka_options and bigquery_options files, removing redundant inline parameter definitions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.77%. Comparing base (4328a13) to head (0df25a9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3178      +/-   ##
============================================
- Coverage     50.80%   50.77%   -0.04%     
+ Complexity     5118     5114       -4     
============================================
  Files           976      976              
  Lines         59996    59996              
  Branches       6555     6555              
============================================
- Hits          30483    30464      -19     
- Misses        27377    27392      +15     
- Partials       2136     2140       +4     
Components Coverage Δ
spanner-templates 70.94% <ø> (-0.07%) ⬇️
spanner-import-export 68.85% <ø> (-0.16%) ⬇️
spanner-live-forward-migration 80.03% <ø> (ø)
spanner-live-reverse-replication 77.69% <ø> (-0.05%) ⬇️
spanner-bulk-migration 88.48% <ø> (ø)
see 7 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw marked this pull request as ready for review January 4, 2026 03:20
@derrickaw derrickaw requested a review from tarun-google January 4, 2026 03:28
Copy link
Contributor

@tarun-google tarun-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrickaw derrickaw merged commit a8c843a into GoogleCloudPlatform:main Jan 5, 2026
14 checks passed
@derrickaw derrickaw deleted the updateKafkaToBigqueryYamlTemplate branch January 5, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants