-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[DatastreamToSpanner, SpannerToSourceDb, SourceDbToSpanner] Remove hardcoded VPC parameters from integration tests #3179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @darshan-sj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the integration test setup for DatastreamToSpanner and SpannerToSourceDb templates by removing explicit VPC network configurations. This change is feasible because disabling public IPs for worker machines has eliminated the previous public IP address quota issues, making a dedicated VPC network unnecessary for these tests and simplifying their execution. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3179 +/- ##
============================================
- Coverage 50.80% 50.80% -0.01%
- Complexity 5118 5495 +377
============================================
Files 976 976
Lines 59996 59996
Branches 6555 6555
============================================
- Hits 30482 30481 -1
Misses 27377 27377
- Partials 2137 2138 +1
🚀 New features to boost your workflow:
|
A separate VPC network is not required now since we disable public ips for the worker machines. We don't run into public ip address quota issue.