Merge v1.96.0 into Develop#5892
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request bumps the HPC Toolkit version to v1.96.0 and introduces functional improvements to the GKE job orchestrator. The changes refine how Pathways platform keys are generated by leveraging full accelerator type information rather than partial strings, along with added test coverage to ensure reliable hardware requirement mapping for TPU-based workloads. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the toolkit version from v1.95.0 to v1.96.0 across various Terraform modules and the Go configuration. It also refactors the GKE manifest generator to pass the original accelerator type directly to the node selector label generator, resolving issues with JAX/Pathways platform key mapping, and introduces a new unit test suite to verify this behavior. There are no review comments, so I have no additional feedback to provide.
Merge v1.96.0 into Develop
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.