Update the default HTCondor and packer versions

[toscar82]

Updating the default HTCondor version from the ancient 23. to 25.
Updating packer version

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs routine dependency maintenance by upgrading the default HTCondor version to the 25.0 release series and updating the Packer version to 1.15.4. These changes ensure that the infrastructure components remain current with the latest stable releases.

Highlights

• HTCondor Version Upgrade: Updated the default HTCondor version from 23.0 to 25.0 across Ansible configuration files and Terraform variables.
• Packer Version Update: Bumped the Packer version from 1.15.3 to 1.15.4 in the Dockerfile and dependency management script.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the HTCondor installation scripts and variables to target version 25.0 (up from 23.0) and bumps the Packer version to 1.15.4 in the Dockerfile and update script. Feedback highlights that pkg/dependencies/checksums_generated.go must be regenerated to reflect the new Packer version, and points out a minor typo with an extra closing parenthesis in the condor_version variable description.

[aslam-quad]

Hi @toscar82

The pre-commit checks are failing in this PR. Could you please resolve the pre-commit issues.

Thanks!

[Neelabh94]

Please fix the pre-commit failure as well.

[Neelabh94]

/gcbrun

[Neelabh94]

Triggered the relevant tests, will review once they finish successfully

[toscar82]

@Neelabh94 could you help me with fixing the pre-commit failures? I have no idea what that problem is, nor how to fix it.
https://github.com/GoogleCloudPlatform/cluster-toolkit/actions/runs/29036083768/job/86372255628?pr=5921

[Neelabh94]

@toscar82 the issue is a go formatting issue. Running go fmt locally and staging the changes will help you resolve it.

Also, you can follow the guide here: https://github.com/GoogleCloudPlatform/cluster-toolkit#development to install all pre-commit hooks locally. This will help you catch such failures early locally.

[toscar82]

pre-commit hook has been set.

the unit test fails:

=== RUN   Test
Test prompt [Y/n]: Test prompt [Y/n]: 2026-07-10T14:49:06Z Usage:       packer dbname
  if dbname is not specified, will use compiled in default of (/usr/share/cracklib/pw_dict).

----------------------------------------------------------------------
FAIL: packer_test.go:26: MySuite.TestPacker

packer_test.go:45:
    c.Assert(err, IsNil)
... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0x1d4db0295920), Stderr:[]uint8(nil)} ("exit status 255")

OOPS: 9 passed, 1 FAILED
--- FAIL: Test (0.01s)
FAIL
FAIL    hpc-toolkit/pkg/shell   0.022s

[toscar82]

@Neelabh94 found the problem with my pre-commit tests. It was caused by a non-hashicorp packer package on my system.

[Neelabh94]

/gcbrun

[mufaqam-gcl]

nit: seems like a typo where we are repeating combined_query_str twice