Skip to content

Comments

samples(Storage): Generalize move object sample for all buckets#3286

Open
mahendra-google wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
mahendra-google:move_object
Open

samples(Storage): Generalize move object sample for all buckets#3286
mahendra-google wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
mahendra-google:move_object

Conversation

@mahendra-google
Copy link
Contributor

This PR contains changes in MoveObject sample to generalize it for all types of buckets. Please see b/429345064.

- Update MoveObject sample to handle standard and non-standard buckets
- Update corresponding integration test
@mahendra-google mahendra-google requested review from a team as code owners January 5, 2026 12:20
@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Jan 5, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @mahendra-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the MoveObject sample by generalizing its functionality. Previously, the sample was implicitly tied to hierarchical namespace (HNS) enabled buckets. The changes ensure that the sample, its documentation, and its corresponding tests are now universally applicable to any Google Cloud Storage bucket, thereby improving its versatility and ease of use for developers.

Highlights

  • Generalize MoveObject Sample: The MoveObject sample code and its associated documentation have been updated to remove specific references to 'hierarchical namespace enabled buckets', making the sample applicable to all types of Google Cloud Storage buckets.
  • Test Fixture Refinement: The StorageFixture.cs test helper class has been modified to remove the CollectHnsObject method, streamlining object collection in tests by using a more generic Collect method.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly generalizes the MoveObject sample to work with all bucket types, removing the specific dependency on Hierarchical Namespace enabled buckets. The changes are reflected in the sample's code, comments, and tests, which now use a generic bucket. The removal of the unused CollectHnsObject helper method in StorageFixture.cs is also a good cleanup. I have one suggestion to improve the code's readability.

@cojenco cojenco removed their assignment Jan 5, 2026
@mahendra-google mahendra-google marked this pull request as draft January 27, 2026 05:18
@mahendra-google mahendra-google marked this pull request as ready for review January 27, 2026 05:18
@amanda-tarafa amanda-tarafa removed their assignment Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants