Skip to content

Comments

feat(secretmanager): Add secret rotation samples#3296

Open
khilan-crest wants to merge 37 commits intoGoogleCloudPlatform:mainfrom
khilan-crest:cs_rotation_samples
Open

feat(secretmanager): Add secret rotation samples#3296
khilan-crest wants to merge 37 commits intoGoogleCloudPlatform:mainfrom
khilan-crest:cs_rotation_samples

Conversation

@khilan-crest
Copy link

Add secret rotation samples

@khilan-crest khilan-crest requested review from a team as code owners January 28, 2026 07:30
@snippet-bot
Copy link

snippet-bot bot commented Jan 28, 2026

Here is the summary of changes.

You are about to add 29 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jan 28, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the C# client library for Google Cloud Secret Manager by introducing a wide array of new code samples. These samples aim to provide developers with clear, practical examples for advanced secret management functionalities, including automated secret rotation, time-based expiration, integration with resource tags for better organization, and the use of Customer-Managed Encryption Keys for enhanced security. The additions also cover improved secret discoverability through filtered listing operations and comprehensive metadata management.

Highlights

  • New Secret Management Samples: A comprehensive suite of C# samples has been added for Google Cloud Secret Manager, covering various secret lifecycle and metadata management operations.
  • Secret Rotation and Expiration: New samples demonstrate how to create, update, and delete secret rotation and expiration configurations for both global and regional secrets.
  • Tag Management: Examples are included for binding, detaching, and listing tags associated with secrets, supporting both global and regional contexts.
  • Filtering and Metadata: Samples for listing secret versions with filters (e.g., by state) and listing secrets with filters (e.g., by labels) are now available.
  • Customer-Managed Encryption Keys (CMEK): Samples for creating secrets with Customer-Managed Encryption Keys (CMEK) are added, for both global and regional deployments.
  • Metadata Deletion: Implemented samples for managing secret metadata, specifically for deleting annotations and labels.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comprehensive set of samples and tests for secret rotation and related features in Secret Manager. The additions are valuable. However, there are several critical issues in the tests that need to be addressed:

  • Many of the new tests rely on helper methods in the test fixtures (e.g., CreateSecretWithExpireTime, CreateSecretWithRotation) which have not been implemented. This will cause compilation failures. These helper methods need to be added to SecretManagerFixture and RegionalSecretManagerFixture.
  • Several tests create resources (secrets, tags) but fail to clean them up, which will lead to resource leaks in the test project.
  • There's a bug in DeleteSecretExpirationTests where the wrong secret is deleted.
  • A few other minor issues like incorrect logging, exception handling, and filename mismatches are also present.

I've added specific comments on the relevant files. Addressing these issues will improve the correctness and reliability of the new samples and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants