samples(Storage): Add samples and tests for bucket encryption enforcement configuration#3313
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @mahendra-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Cloud Storage C# samples by introducing new functionalities for managing bucket encryption enforcement. It provides developers with clear examples and robust tests for setting, retrieving, and removing encryption policies, thereby improving data security and compliance options for their storage buckets. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new samples and corresponding tests for managing bucket encryption enforcement configurations, including setting, getting, and removing them. The new code is well-structured and the tests provide good coverage for the new samples. I have one suggestion to refactor a small part of the logic in one of the samples to improve its clarity and maintainability. Overall, this is a solid contribution.
storage/api/Storage.Samples/BucketSetEncryptionEnforcementConfig.cs
Outdated
Show resolved
Hide resolved
b9b9c6f to
b375f88
Compare
…ment configuration (http:/b/465329369)
4d58b52 to
c3096a6
Compare
This PR includes samples and tests for the following bucket encryption enforcement operations:
Please see b/465329369.