Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"google/auth": "^1.12",
"google/cloud-tools": "dev-main",
"guzzlehttp/guzzle": "^7.0",
"phpunit/phpunit": "^9.0",
"phpunit/phpunit": "^13.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating phpunit/phpunit to ^13.0 introduces critical dependency conflicts that will prevent dependencies from being installed:

  1. PHP Version Mismatch: PHPUnit 13 requires PHP ^8.3, but this composer.json file only requires PHP ^8.1. This will cause composer install to fail in environments running PHP 8.1 or 8.2.
  2. phpspec/prophecy-phpunit Incompatibility: The version of phpspec/prophecy-phpunit (^2.0) used in this project is not compatible with PHPUnit 13. It only supports up to PHPUnit 11, which will cause a dependency resolution failure.

Furthermore, upgrading from PHPUnit 9 to 13 is a significant undertaking due to numerous breaking changes. This upgrade should be performed incrementally (e.g., 9 -> 10, 10 -> 11, etc.) to manage the migration of test code. Simply bumping the version number is not feasible.

"friendsofphp/php-cs-fixer": "^3.29",
"composer/semver": "^3.2",
"phpstan/phpstan": "^2.0",
Expand Down
Loading