Update mypy to the latest 2.3#1656
Open
linsword13 wants to merge 1 commit into
Open
Conversation
Also fix up typing issues reported by the new version.
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds type annotations to various command and utility modules in the Ramble codebase, typing dictionaries and lists that hold command formatters, subcommands, arguments, strategies, and modules. It also updates the pinned version of mypy in requirements-pinned.txt. However, the reviewer noted that mypy version 2.3.0 does not exist on PyPI, which will cause installation failures, and suggested pinning to a valid 1.x version instead.
Ramble Performance Test MetricsResults produced with commit: b10987d
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1656 +/- ##
========================================
Coverage 93.31% 93.31%
========================================
Files 353 353
Lines 34334 34342 +8
========================================
+ Hits 32039 32047 +8
Misses 2295 2295 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix up typing issues reported by the new version.