Validate Scaling for the OSU Microbenchmarks#1657
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds validation logic to ensure that specific OSU Micro Benchmarks workloads are run with exactly two ranks. The review feedback identifies a critical bug where the validation predicate logic is inverted (failing when ranks equal two instead of when they do not), lists several missing workloads that should also be restricted to two ranks, and points out PEP 8 style violations and redundant arguments in the validator registration.
|
I have confirmed Lawrence Livermore National Security, LLC has a Contributor License Agreement in place with Google/Alphabet per our General Counsel. We do not, however, use Google Groups or Google Apps for Business. Is this now a hard requirement for PRs? |
|
@nhanford I dot not believe so. I triggered a re-run of the CLA check though, so lets see what happens. |
Currently, the
application.pyfor the OSU Microbenchmarks does not validate workloads that must be run on 2 and only 2 ranks. This modification will add a validator to ensure that these workloads are not attempted for invalid rank scaling. For example, attempting to run 10,000 ranks ofosu_bibwshould fail instead of attempting to run.