Skip to content

Fix-up and minor improvements - #1664

Merged
dapomeroy merged 2 commits into
GoogleCloudPlatform:developfrom
linsword13:code-cleanup
Jul 22, 2026
Merged

Fix-up and minor improvements#1664
dapomeroy merged 2 commits into
GoogleCloudPlatform:developfrom
linsword13:code-cleanup

Conversation

@linsword13

Copy link
Copy Markdown
Member

These are things Gemini found, and I've vetted them for correctness.

These are things Gemini found, and I've vetted them for correctness.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@linsword13

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@ramble-pr-bot

ramble-pr-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 03880f5

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.9693 2.9723 (aceabce) 2.9885
test_large_template_expansion passed 2.1550 2.1655 (aceabce) 2.1697
test_many_experiments passed 37.2580 37.3730 (aceabce) 38.0145
test_many_objects_defaults passed 20.9951 20.7513 (aceabce) 20.7984
test_matrix_filter_perf passed 1.6203 1.6220 (aceabce) 1.6283

@linsword13

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several code quality improvements, optimizations, and simplifications across the codebase. Key changes include optimizing loop logic by hoisting set comprehensions and using dictionary key intersections, simplifying file extension checks with tuples in endswith, replacing manual inspection with inspect.signature, utilizing standard library utilities like textwrap.indent and os.path.relpath, fixing typos in warning messages, and improving performance by using collections.deque for queue operations. No review comments were provided, so there is no additional feedback to address.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.27%. Comparing base (aceabce) to head (03880f5).

Files with missing lines Patch % Lines
lib/ramble/ramble/cmd/clean.py 0.00% 1 Missing ⚠️
lib/ramble/ramble/repository.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1664   +/-   ##
========================================
  Coverage    93.27%   93.27%           
========================================
  Files          366      366           
  Lines        35217    35206   -11     
========================================
- Hits         32850    32840   -10     
+ Misses        2367     2366    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dapomeroy dapomeroy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapomeroy
dapomeroy merged commit 06fd88f into GoogleCloudPlatform:develop Jul 22, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants