EDIT-2: timestamped status notes in node quick-edit (TDD)#111
Merged
Conversation
Adds editable, timestamped status updates (like comments) to the node quick-edit popover, stored under metadata.statusNotes. Completes #96's primary ask. - New pure lib/statusNotes.ts (add/edit/delete/get) — unit-tested first (7/7), handles metadata as object OR JSON string. - NodeQuickEdit: "Status notes" section — add (timestamped), inline-edit, delete; metadata is serialized to a JSON STRING on write (the schema's metadata field is String — sending an object silently failed; that was the bug the reload test caught), parsed on read. - Quick-edit overlay sources field data from the Apollo nodes array (fresh) for position from the sim node, so reopened editors show saved values. Tests: statusNotes unit 7/7; node-quick-edit @quickedit 3/3 incl. "add a note → survives full reload → delete". THE GATE unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #96's primary ask: editable, timestamped status updates (like comments) on each node, in the quick-edit popover, stored under
metadata.statusNotes.lib/statusNotes.ts(add/edit/delete/get) — unit-tested first (7/7); handles metadata as object or JSON string.NodeQuickEdit"Status notes": add (timestamped) / inline-edit / delete. metadata is serialized to a JSON string on write — the schema'smetadatafield isString, so sending an object silently failed (caught by the reload test); reads parse it back.nodesarray (position from the sim node), so reopened editors show saved values.Cloud Worker side (separate, already deployed): migration
0003addsnodes.metadata; create/update persist it, reads return it — verified the note round-trips on production.Tests:
statusNotesunit 7/7;node-quick-edit @quickedit3/3 incl. add note → survives full reload → delete. Typecheck clean.🤖 Generated with Claude Code