Node UX PR-2: docked Card/Contents/Diagram inspector (decouple legibility from zoom)#67
Merged
Merged
Conversation
… (PR-2) Selecting a node opens a docked right-hand inspector with an explicit Card · Contents · Diagram toggle (per-node, session-remembered), each rendered at full legible size regardless of canvas zoom — replacing the old "zoom in to make text readable" anti-pattern. - Contents renders node.description as readable markdown + syntax-highlighted code (lazy NodeContentRenderer). - Diagram draws the node's sub-graph statically from persisted positions (NodeSubgraphPreview), capped to 300 nodes / 600 edges so even the 1000-node Compute Core sub-graph previews instantly; "Open" descends in. - Plain node click now SELECTS (opens inspector) instead of descending; sheet nodes descend via the explicit ⤢ glyph or the inspector's Open button, so a click never navigates you away unexpectedly. - handleClickOutside ignores clicks inside the inspector so its own controls don't deselect the node and close it. - Selection lifted to Workspace via onNodeSelected through SafeGraphVisualization. Verified: tests/diagnostics/node-inspector.spec.ts (Contents/Diagram/Card + legible-when-zoomed-out) and hierarchy-navigation.spec.ts green; THE GATE 5/5. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a node opens a docked right-hand inspector with an explicit
Card · Contents · Diagram toggle (per-node, remembered for the session),
each rendered at full legible size regardless of canvas zoom — directly
addressing the "zoom in to a tiny unreadable diagram → tiny code → finally
readable code" problem. Mode switching is intentional, not a side effect of zoom.
What's in it
node.descriptionrendered as readable GitHub-flavored markdownNodeContentRendererfrom PR-1).(
NodeSubgraphPreview), capped to 300 nodes / 600 edges so even the 1000-node"Compute Core" sub-graph previews instantly; Open descends in.
descending a sheet node is the explicit ⤢ glyph or the inspector's Open — a
click never navigates you away unexpectedly.
handleClickOutsideignores clicks inside the inspector so its own controlsdon't deselect the node and close it.
WorkspaceviaonNodeSelectedthroughSafeGraphVisualization.Verification
tests/diagnostics/node-inspector.spec.ts— select node → inspector opens →Contents renders markdown → Diagram renders the sub-graph preview + Open →
Card shows summary → zoom way out, Contents still readable. green
tests/diagnostics/hierarchy-navigation.spec.tsupdated for glyph-descend. greenTEST_URL=http://localhost:3127 npm run test:smoke) 5/5.Stacked on PR-1 (#66, merged). Next: PR-3 (on-canvas expand-in-place), PR-4 (card legibility floor).
🤖 Generated with Claude Code