Fix #30: node type change updates the card in graph view#73
Merged
Conversation
…order/icon) Changing a node's type elsewhere (dashboard/editor) updated the badge text in the graph but not the type-derived card color/border/icon — the selective update path (updateVisualizationData) refreshes text but not type visuals, and the reinit gatekeeper only watched edge signatures + node COUNT (a type change keeps count the same). Add a per-node id+type signature: when it changes, force a full reinitialization (same approach already used for edge type/flip), so the card re-renders with the new type's color, border and icon. Fixes #30. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30.
Bug: changing a node's type (e.g. from the dashboard/editor) updated the
type badge text in the graph but left the card's type-derived color, border
and icon stale.
Root cause: a type change keeps node count + edge signature the same, so the
reinit gatekeeper ran the selective
updateVisualizationData()path — whichrefreshes title/badge/description text but not the type visuals.
Fix: add a per-node
id:typesignature to the gatekeeper (mirroring theexisting edge type/flip signature). When it changes, force a full reinit so the
card re-renders with the new type's color/border/icon.
Verification note: validated by root-cause analysis; the local dev box is at load
~27 (shared LLM services), so CI's clean runners are authoritative here.